Prevent user from accidentally triggering multiple identity resets #29388
Conversation
uhoreg
force-pushed
the
prevent_multiple_reset_identity
branch
from
35c88ab to
b688f2b
Compare
uhoreg
force-pushed
the
prevent_multiple_reset_identity
branch
from
b688f2b to
f8922b2
Compare
|
I have a question in the linked issue about the wording on the button, but this should otherwise be ready for initial review. |
| let resolveResetEncryption; | ||
| const resetEncryptionPromise: Promise<void> = new Promise((resolve) => { | ||
| resolveResetEncryption = resolve; | ||
| }); |
There was a problem hiding this comment.
We can use defer here instead
There was a problem hiding this comment.
There was a problem hiding this comment.
Which is built-in, better to use t3chguy option
There was a problem hiding this comment.
When I try to use withResolvers, TypeScript complains, saying that I need to set "the 'lib' compiler option to 'es2024' or later", which I'm not sure if it is something I should do. So I'll use defer for now.
| </Button> | ||
| {inProgress ? ( | ||
| <EncryptionCardEmphasisedContent> | ||
| <span className="text-warning"> |
There was a problem hiding this comment.
Can we use compound variable here instead of global test-warning which is relying on $alert
There was a problem hiding this comment.
Sorry, I don't know understand exactly what you mean here. Should I be creating a new style and use var(--cpd-color-text-critical-primary)? Or is there a different class or element that I should be using?
There was a problem hiding this comment.
8f9d93c creates a new CSS class which uses the compound variable -- hopefully that is what was intended.
richvdh
force-pushed
the
prevent_multiple_reset_identity
branch
from
419ac8a to
8f9d93c
Compare
Part of #29192
When the user clicks the Continue button to reset their identity, show a spinner, disable the button, and warn them not to close the window.
Checklist
public/exportedsymbols have accurate TSDoc documentation.