Room List Store: Filter rooms by active space #29399
Open
+153
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MidhunSureshR
force-pushed
the
midhun/rls/filter-by-space
branch
from
b9e54bb to
643fda8
Compare
MidhunSureshR
force-pushed
the
midhun/rls/filter-by-space
branch
from
643fda8 to
19ed3e9
Compare
MidhunSureshR
commented
Mar 3, 2025
| * Returns a promise that resolves when the space store is ready. | ||
| * This happens after an initial hierarchy of spaces and rooms has been computed. | ||
| */ | ||
| public get isReady(): Promise<void> { |
There was a problem hiding this comment.
This is to prevent the room list store from calling methods on the space store before the space store has computed an initial space hierarchy.
MidhunSureshR
force-pushed
the
midhun/rls/filter-by-space
branch
from
982057f to
ce338a8
Compare
MidhunSureshR
force-pushed
the
midhun/rls/updates
branch
from
9cd1f3f to
9465811
Compare
MidhunSureshR
force-pushed
the
midhun/rls/filter-by-space
branch
from
ce338a8 to
c40acd7
Compare
Otherwise, the room list store will get incorrect information about spaces and thus will produce an incorrect roomlist.
Implement a way to filter by active space
MidhunSureshR
force-pushed
the
midhun/rls/filter-by-space
branch
from
c40acd7 to
81ea160
Compare
t3chguy
reviewed
Mar 3, 2025
| * Returns a promise that resolves when the space store is ready. | ||
| * This happens after an initial hierarchy of spaces and rooms has been computed. | ||
| */ | ||
| public get isReady(): Promise<void> { |
There was a problem hiding this comment.
isReady sounds like it returns a boolean, the naming does not describe a promise which resolves when ready, could you pick a better name?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ideally the room list store would give more information about spaces (and the ability to filter by arbitrary spaces) but this should be sufficient for the time being.