Add more functionality to the room list vm #29402
Draft
+491
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
MidhunSureshR
commented
Mar 3, 2025
MidhunSureshR
commented
- Listen for updates from the store
- Provide a method to open rooms
MidhunSureshR
force-pushed
the
midhun/rls/filter-by-space
branch
from
982057f to
ce338a8
Compare
- Make if/else more consistent - Add comment on findAndAddRoom()
On a timeline action, we return early if payload.room is falsy. So then why do we need to retry fetching the room? I think this can be removed but will ask others if there's some conext I'm missing.
Otherwise, the room list store will get incorrect information about spaces and thus will produce an incorrect roomlist.
Implement a way to filter by active space
MidhunSureshR
force-pushed
the
midhun/rls/filter-by-space
branch
from
ce338a8 to
c40acd7
Compare
- Listen for updates from the store - Provide a method to open rooms
MidhunSureshR
force-pushed
the
midhun/rls/room-list-vm-2
branch
from
3719642 to
ccbded1
Compare
MidhunSureshR
force-pushed
the
midhun/rls/filter-by-space
branch
from
c40acd7 to
81ea160
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.