Migrate to coil3

[bmarty]

Content

Migrate from coil2 to coil3

Ref: https://coil-kt.github.io/coil/upgrading_to_coil3/

Motivation and context

Use up to date dependencies.

Screenshots / GIFs

Tests

• Check that images (avatar, media in rooms, etc.) are correctly loaded
• Signout and signin using another account. Images should be loaded correctly.

Tested devices

• Physical
• Emulator
• OS version(s):

Checklist

• Changes have been tested on an Android device or Android emulator with API 24
• UI change has been tested on both light and dark themes
• Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
• Pull request is based on the develop branch
• Pull request title will be used in the release note, it clearly define what will change for the user
• Pull request includes screenshots or videos if containing UI changes
• You've made a self review of your PR

[bmarty]

This does not seem to be used, not sure what's happening here.

[ganfra]

What is not used exactly?

[bmarty]

I set a breakpoint on okHttpClient.get() and starts the application in debug mode (from AS). Images are loaded but the code never breaks.

[ganfra]

This sounds wrong then :/
According to the documentation, should be enough

[bmarty]

I have added logs and confirm that this code is not used. Still digging

[github-actions]

📱 Scan the QR code below to install the build (arm64 only) for this PR.

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/tJPwY2

[codecov]

Codecov Report

Attention: Patch coverage is 31.25000% with 33 lines in your changes missing coverage. Please review.

Project coverage is 80.17%. Comparing base (491bb1d) to head (299f2fb).

Files with missing lines	Patch %	Lines
...roid/libraries/matrix/ui/media/CoilMediaFetcher.kt	0.00%	13 Missing ⚠️
.../libraries/matrix/ui/media/ImageLoaderFactories.kt	0.00%	11 Missing ⚠️
...android/libraries/designsystem/components/Bloom.kt	0.00%	5 Missing ⚠️
...ent/android/features/location/api/StaticMapView.kt	75.00%	0 Missing and 2 partials ⚠️
...l/notifications/DefaultNotificationBitmapLoader.kt	0.00%	0 Missing and 2 partials ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #4347      +/-   ##
===========================================
- Coverage    80.18%   80.17%   -0.02%     
===========================================
  Files         2058     2058              
  Lines        54802    54815      +13     
  Branches      6706     6706              
===========================================
+ Hits         43945    43949       +4     
- Misses        8561     8570       +9     
  Partials      2296     2296              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud