Remove effects vector

elishacloud · Dec 2, 2024 · 986654f · 986654f
1 parent 9932160
commit 986654f
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 10 deletions.
diff --git a/BuildNo.rc b/BuildNo.rc
@@ -1 +1 @@
-#define BUILD_NUMBER 80 
+#define BUILD_NUMBER 81 
diff --git a/IDirectInputDeviceX.cpp b/IDirectInputDeviceX.cpp
@@ -791,7 +791,6 @@ HRESULT m_IDirectInputDeviceX::CreateEffect(REFGUID rguid, LPCDIEFFECT lpeff, LP
 		Logging::LogDebug() << __FUNCTION__ << " (" << this << ") Failed! hr: " << (DIERR)hr;
 
 		m_IDirectInputEffect* pEffect = CreateEffectWrapper(nullptr);
-		effects.push_back(pEffect);
 
 		// Return an effect class even on failure becasue some games don't check for failure
 		*ppdeff = pEffect;

diff --git a/IDirectInputDeviceX.h b/IDirectInputDeviceX.h
@@ -18,9 +18,6 @@ class m_IDirectInputDeviceX : public AddressLookupTableDinputObject
 	void *WrapperInterface2 = nullptr;
 	void *WrapperInterface7 = nullptr;
 
-	// Vector to store instances of m_IDirectInputEffect
-	std::vector<m_IDirectInputEffect*> effects;
-
 	// For SetCooperativeLevel
 	bool IsMouse = false;
 
@@ -131,11 +128,6 @@ class m_IDirectInputDeviceX : public AddressLookupTableDinputObject
 	{
 		LOG_LIMIT(3, __FUNCTION__ << " (" << this << ")" << " deleting interface!");
 
-		for (auto& entry : effects)
-		{
-			entry->DeleteMe();
-		}
-
 		// Delete Critical Section
 		DeleteCriticalSection(&dics);