Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix warning in tests and some doctest whitespace #14194

Merged
merged 4 commits into from
Jan 17, 2025
Merged

Fix warning in tests and some doctest whitespace #14194

merged 4 commits into from
Jan 17, 2025

Conversation

sabiwara
Copy link
Contributor

@sabiwara sabiwara commented Jan 17, 2025 •
edited
Loading

Micro cleanup commits 🧹

Screenshot 2025-01-17 at 10 56 12

josevalim
josevalim reviewed Jan 17, 2025
View reviewed changes
lib/elixir/test/elixir/version_test.exs Outdated
assert_raise(FunctionClauseError, fn ->
Version.compile_requirement("~> 1.2.3")
Version.compile_requirement(string)
end)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my opinion we should remove this one but it is also fine to leave it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I hesitated, I like the idea of ensuring the runtime behavior in such a case but happy to just remove if you prefer 👍

@sabiwara sabiwara merged commit 6e3de5f into elixir-lang:main Jan 17, 2025
8 of 9 checks passed
@sabiwara sabiwara deleted the micro-clean branch January 17, 2025 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josevalim josevalim josevalim approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sabiwara @josevalim