chore: remove debug printS

elixir-nx · Sep 9, 2024 · 1fa784d · 1fa784d
1 parent b4a215a
commit 1fa784d
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 9 deletions.
diff --git a/exla/c_src/exla/exla.cc b/exla/c_src/exla/exla.cc
@@ -550,7 +550,6 @@ ERL_NIF_TERM create_buffer_from_device_pointer(ErlNifEnv* env, int argc, const E
 
   EXLA_ASSIGN_OR_RETURN_NIF(xla::PjRtDevice * device, (*client)->client()->LookupDevice(xla::PjRtGlobalDeviceId(device_id)), env);
 
-  std::function<void()> on_delete_callback = []() {};
   EXLA_ASSIGN_OR_RETURN_NIF(std::unique_ptr<xla::PjRtBuffer> buffer, (*client)->client()->CreateViewOfDeviceBuffer(ptr, shape, device, on_delete_callback), env);
 
   exla::ExlaBuffer* exla_buffer = new exla::ExlaBuffer(std::move(buffer));

diff --git a/exla/c_src/exla/ipc.cc b/exla/c_src/exla/ipc.cc
@@ -24,14 +24,11 @@ int get_ipc_handle(const char* memname, size_t memsize) {
 
 // Function to map the shared memory in this process
 void* open_ipc_handle(int fd, size_t memsize) {
-  std::cout << "fd: " << fd << std::endl;
-  std::cout << "memsize: " << memsize << std::endl;
   void* ptr = mmap(NULL, memsize, PROT_READ | PROT_WRITE, MAP_SHARED, fd, 0);
   if (ptr == MAP_FAILED) {
     perror("mmap");
     return nullptr;
   }
-  std::cout << "ptr: " << ptr << std::endl;
   return ptr;
 }
 

diff --git a/exla/lib/exla/backend.ex b/exla/lib/exla/backend.ex
@@ -108,11 +108,9 @@ defmodule EXLA.Backend do
 
     case EXLA.NIF.get_buffer_device_pointer(client.ref, buffer.ref, mode) do
       {:ok, result} ->
-        dbg(result)
-
         handle =
           case {result, mode} do
-            {{ptr, size}, :local} when is_integer(ptr) ->
+            {{ptr, _size}, :local} when is_integer(ptr) ->
               # pointer is an integer here
               ptr
 

diff --git a/exla/test/exla/device_memory_sharing_test.exs b/exla/test/exla/device_memory_sharing_test.exs
@@ -15,7 +15,7 @@ defmodule EXLA.DeviceMemorySharingTest do
 
       assert {:ok, t2} =
                Nx.from_pointer(
-                 {EXLA.Backend, client_name: unquote(client_name)},
+                 {EXLA.Backend, client: unquote(client_name)},
                  pointer,
                  t1.type,
                  t1.shape
@@ -30,7 +30,7 @@ defmodule EXLA.DeviceMemorySharingTest do
   test "ipc handles don't crash the runtime when :local mode is selected" do
     assert {:error, ~c"Invalid pointer size for selected mode."} ==
              Nx.from_pointer(
-               {EXLA.Backend, client_name: :cuda},
+               {EXLA.Backend, client: :cuda},
                Enum.to_list(0..63),
                {:f, 32},
                {1},