feat: add EXLA.to_mlir_module/2 #1497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
polvalente
commented
May 23, 2024
polvalente
commented
- feat: add EXLA.to_mlir_module/3
- doc: add doctest
polvalente
commented
May 23, 2024
| @@ -71,6 +71,10 @@ defmodule EXLA.MLIR.Module do | |||
| * `:use_spmd` - enables Single-Program Multiple-Data partioning. | |||
| This is set to true if `:num_partitions` is more than one, otherwise is `false`. | |||
|
|
|||
| * `:module_compilation` - either `:to_mlir` or `:to_pjrt`. The default is `:to_pjrt`. | |||
There was a problem hiding this comment.
@josevalim not sure about the option naming here
There was a problem hiding this comment.
It is private, so it is fine!
There was a problem hiding this comment.
If we return %EXLA.MLIR.Module{} in the other function, shouldn't the whole module be public?
There was a problem hiding this comment.
Good catch. We should return the string only, not the module struct.
There was a problem hiding this comment.
The public-facing function is now returning the binary directly
josevalim
reviewed
May 24, 2024
Comment on lines
+381
to
+382
| {:ok, {_xla_time, executable, _extra, _outfeed}} = callback.() | ||
| throw({:mlir_module, executable.ref}) |
There was a problem hiding this comment.
Gah, this is relying on internals of another module but I can't think of anything better for now, so ship it.
josevalim
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.