Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add severed_relationships notification type #3134

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

poopsicles
Copy link

@poopsicles poopsicles commented Jan 13, 2025

kind of a follow-up to #3077 and #3084, which added the console logging for unsupported noti types, but not the notification for severed_relationships.

it looks like:
image

compared to my instance's:
image

copied the language from upstream, I can probably just use their localisations too, right?

I'll probably expand the PR to add in moderation_warning if I can get a pic of how it should look like (or barring that, just copying upstream's impl)

(and maybe refactor annual_report to use localisations too?)

(also a bit unsure if i'm following the pluralisation guidelines, but hey, that's why it's a draft PR)

Copy link

netlify bot commented Jan 13, 2025

Deploy Preview for elk-docs canceled.

Name Link
🔨 Latest commit 5aa2b31
🔍 Latest deploy log https://app.netlify.com/sites/elk-docs/deploys/678a588ae079d50008a68529

Copy link

netlify bot commented Jan 13, 2025

Deploy Preview for elk-zone ready!

Name Link
🔨 Latest commit 5aa2b31
🔍 Latest deploy log https://app.netlify.com/sites/elk-zone/deploys/678a588a6883a00007e1e275
😎 Deploy Preview https://deploy-preview-3134--elk-zone.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@shuuji3
Copy link
Member

shuuji3 commented Jan 15, 2025

Yes, using upstream localization is a smart idea.👍🏻

It's also nice to have moderation_warning. I did a quick search but couldn't find an actual screenshot (I only found a moderation-side UI: https://community.hachyderm.io/blog/2024/09/01/hachyderms-introduction-to-mastodon-moderation-the-report-feature-and-moderator-actions/). I think it's fine to assume UI and adjust for Elk from Mastodon's source code.

Those expansions can be included in this PR or separated if you'd like.

@shuuji3
Copy link
Member

shuuji3 commented Jan 15, 2025

Probably not applicable in this case. Those are usually for short-string localization. But I'll review the guidelines later.

Also probably we'll need another type than object. Checking masto.js docs might help: https://neet.github.io/masto.js/

</p>

<NuxtLink :to="`https://${currentServer}/severed_relationships`" target="_blank">
Learn more
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can mark these words as translatable.

@shuuji3 shuuji3 changed the title add severed_relationships notification type feat: add severed_relationships notification type Jan 17, 2025
@shuuji3
Copy link
Member

shuuji3 commented Jan 17, 2025

OK, I just fixed type check errors. Those are a bit complicated. One type of error requires yo update type definition in the upstream library, masto.js. The other one was due to a failure of type inference in Vue template. Anyway, you don't have to worry about them in this PR.

@shuuji3 shuuji3 force-pushed the severed_relationships branch from 74ce35e to 5aa2b31 Compare January 17, 2025 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants