Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add self playing CFR+ state and surrounding code #92

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Add self playing CFR+ state and surrounding code #92

wants to merge 3 commits into from

Conversation

elliottneilclark
Copy link
Owner

@elliottneilclark elliottneilclark commented Feb 21, 2024 •
edited
Loading

Add CFR State, TraversalState, and Agent

This PR doesn't add all the code working yet. It adds the needed base structs and impls that will be needed. It gives the structure for adding CFR.

@elliottneilclark elliottneilclark force-pushed the cfr_node branch 13 times, most recently from 66f7630 to cc13769 Compare February 28, 2024 21:39
@elliottneilclark elliottneilclark changed the title CFR Historian Add self playing CFR+ agent and historian Feb 28, 2024
@elliottneilclark elliottneilclark force-pushed the cfr_node branch 2 times, most recently from 6a578fd to 197a0f7 Compare March 10, 2024 18:12
@elliottneilclark
Copy link
Owner Author

elliottneilclark commented Mar 14, 2024 •
edited
Loading

The current status is that this is making progress, but I need to see why it fails when the state is changed during exploration.

@elliottneilclark elliottneilclark force-pushed the cfr_node branch 7 times, most recently from 9e4f46d to ec6c078 Compare March 25, 2024 13:34
@elliottneilclark elliottneilclark force-pushed the cfr_node branch 4 times, most recently from f213b1e to 0d94e80 Compare April 28, 2024 04:02
@elliottneilclark elliottneilclark force-pushed the cfr_node branch 3 times, most recently from 3d9fd23 to ad9fdbd Compare June 30, 2024 00:13
@elliottneilclark elliottneilclark force-pushed the cfr_node branch 6 times, most recently from 2869486 to 614fdc9 Compare January 2, 2025 16:20
@elliottneilclark elliottneilclark changed the title Add self playing CFR+ agent and historian Add self playing CFR+ state and surrounding code Jan 2, 2025
@elliottneilclark elliottneilclark force-pushed the cfr_node branch 6 times, most recently from 30e4dba to adc7ef3 Compare January 3, 2025 16:47
@elliottneilclark
feat: add counterfactual regret minimization node and state
aef4f1e 
Summary:
- Add CFR game state tree that uses a vec as an allocation arena.
- Add a base cfr agent that can be filled out
- Add a historian that will follow the game for an agent filling out the
  cfr tree.

Test Plan:
- Added a test for CFRState
- Added doc tests for state
@elliottneilclark
test: add disabled test to show what agent should be able to do
a947d4e 
Summary:
- Add a simple test

Test Plan:
- tests are added but ignored for now
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@elliottneilclark