Skip to content
This repository has been archived by the owner on May 24, 2024. It is now read-only.

Support network arg for adding signatures to transaction #389

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

raymens
Copy link
Contributor

@raymens raymens commented Mar 8, 2023

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@raymens raymens marked this pull request as draft March 8, 2023 12:02
@elucidsoft
Copy link
Owner

Looks like the test is failing:

Test method stellar_dotnet_sdk_test.TransactionTest.TestAddPreSignedSignature threw exception: 
stellar_dotnet_sdk.NoNetworkSelectedException: Exception of type 'stellar_dotnet_sdk.NoNetworkSelectedException' was thrown.

@raymens raymens marked this pull request as ready for review October 11, 2023 08:51
@raymens
Copy link
Contributor Author

raymens commented Oct 11, 2023

Thanks, I've updated it to default to Network.Current

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants