Skip to content

Commit

Permalink
lib{c,sys}: expose _getlogin consistently
Browse files Browse the repository at this point in the history
Historically we exposed _getlogin as a private symbol on a per-arch basis
(except on aarch64 and riscv) for no obvious reason.  We now need to
expose it for libc's use so remove the special case from
makesyscalls.lua and expose it in the generated syscalls.map.

Reviewed by:	kib
Differential Revision:	https://reviews.freebsd.org/D44116
  • Loading branch information
brooksdavis committed Feb 29, 2024
1 parent 6d3f4dc commit 304cdac
Show file tree
Hide file tree
Showing 8 changed files with 2 additions and 17 deletions.
4 changes: 0 additions & 4 deletions lib/libc/powerpc64/Symbol.map
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,3 @@ FBSD_1.0 {
fpsetmask;
fpsetround;
};

FBSDprivate_1.0 {
_getlogin;
};
2 changes: 0 additions & 2 deletions lib/libsys/amd64/Symbol.sys.map
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,6 @@ FBSD_1.6 {
*
*/
FBSDprivate_1.0 {
_getlogin;

_brk;
_vfork;
};
1 change: 0 additions & 1 deletion lib/libsys/arm/Symbol.sys.map
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ FBSD_1.0 {
};

FBSDprivate_1.0 {
_getlogin;
_vfork;
_brk;
_sbrk;
Expand Down
1 change: 0 additions & 1 deletion lib/libsys/i386/Symbol.sys.map
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ FBSD_1.6 {
};

FBSDprivate_1.0 {
_getlogin;
_vfork;
_brk;
};
4 changes: 0 additions & 4 deletions lib/libsys/powerpc/Symbol.sys.map
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,3 @@ FBSD_1.0 {
brk;
sbrk;
};

FBSDprivate_1.0 {
_getlogin;
};
4 changes: 0 additions & 4 deletions lib/libsys/powerpc64/Symbol.sys.map
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,3 @@ FBSD_1.0 {
brk;
sbrk;
};

FBSDprivate_1.0 {
_getlogin;
};
1 change: 1 addition & 0 deletions lib/libsys/syscalls.map
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,7 @@ FBSDprivate_1.0 {
__sys_ktrace;
_getgid;
__sys_getgid;
_getlogin;
__sys_getlogin;
_setlogin;
__sys_setlogin;
Expand Down
2 changes: 1 addition & 1 deletion sys/tools/makesyscalls.lua
Original file line number Diff line number Diff line change
Expand Up @@ -924,7 +924,7 @@ local function handle_noncompat(sysnum, thr_flag, flags, sysflags, rettype,
config.syscallprefix, funcalias, sysnum))
write_line("sysmk", string.format(" \\\n\t%s.o",
funcalias))
if funcalias ~= "exit" and funcalias ~= "getlogin" and funcalias ~= "vfork" then
if funcalias ~= "exit" and funcalias ~= "vfork" then
write_line("libsysmap", string.format("\t_%s;\n",
funcalias))
end
Expand Down

0 comments on commit 304cdac

Please sign in to comment.