Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for ember-component-attributes addon #207

Open
Turbo87 opened this issue Dec 14, 2019 · 4 comments · May be fixed by #218
Open

Add support for ember-component-attributes addon #207

Turbo87 opened this issue Dec 14, 2019 · 4 comments · May be fixed by #218
Labels
enhancement New feature or request

Comments

@Turbo87
Copy link
Collaborator

Turbo87 commented Dec 14, 2019

Before:

  {{#link-to "categories" (html-attributes aria-label="Categories")}}{{svg-jar "crate"}}{{/link-to}}

After:

  <LinkTo @route="categories" @model={{html-attributes}}>{{svg-jar "crate"}}</LinkTo>
@Turbo87 Turbo87 added the bug Something isn't working label Dec 14, 2019
@tylerturdenpants
Copy link
Collaborator

Eww. This one looks yucky @Turbo87

@Turbo87
Copy link
Collaborator Author

Turbo87 commented Dec 21, 2019 •
edited
Loading

this one is from https://github.com/mmun/ember-component-attributes btw

and I'm starting to wonder if it's really worth it to support it vs. listing it as a caveat in the README

@tylerturdenpants
Copy link
Collaborator

@Turbo87 I'm working on a fix. Does this transform look correct? I will continue for all other invocations soon.

Before:

  {{#link-to "categories" (html-attributes id="main-bar" class="large" data-foo="123")}}
    {{svg-jar "crate"}}
  {{/link-to}}

After:

  <LinkTo @route="categories" id="main-bar" class="large" data-foo="123">
    {{svg-jar "crate"}}
  </LinkTo>

@tylerturdenpants tylerturdenpants linked a pull request Dec 27, 2019 that will close this issue
Open
@Turbo87
Copy link
Collaborator Author

Turbo87 commented Dec 28, 2019

LGTM

@Turbo87 Turbo87 changed the title @model drops helper arguments Add support for ember-component-attributes addon Dec 30, 2019
@Turbo87 Turbo87 added enhancement New feature or request and removed bug Something isn't working labels Dec 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

WIP: Add support for ember-component-attributes addon ember-codemods/ember-angle-brackets-codemod
2 participants
@Turbo87 @tylerturdenpants