WIP: Add support for ember-component-attributes addon
#218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tylerturdenpants
changed the title
Turbo87
reviewed
Dec 28, 2019
| // eslint-disable-next-line no-unused-vars | ||
| let [_, secondParamInput] = params; | ||
| if (secondParamInput.type === 'SubExpression') { | ||
| let htmlAttrs; | ||
| if (secondParamInput.path.original === 'html-attributes') { |
There was a problem hiding this comment.
I'm not sure if we should do this only for the second param. The addon works for any param AFAIK. Seems like it also only works for LinkTo here?
There was a problem hiding this comment.
I agree. I thought it would be a good idea if I included you in the discussion as I worked on it so I could get your feedback. I only had enough time yesterday to tackle a little bit of the problem. 😄
Turbo87
changed the title
ember-component-attributes addon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #207