Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test eslint fix && with different ts eslint plugin versions #127

Merged
merged 1 commit into from
Jan 30, 2025
Merged

test eslint fix && with different ts eslint plugin versions #127

merged 1 commit into from
Jan 30, 2025

Conversation

patricklx
Copy link
Collaborator

@patricklx patricklx commented Jan 28, 2025 •
edited
Loading

@patricklx patricklx marked this pull request as draft January 28, 2025 16:36
NullVoxPopuli
NullVoxPopuli previously approved these changes Jan 28, 2025
View reviewed changes
@patricklx
Copy link
Collaborator Author

patricklx commented Jan 28, 2025 •
edited
Loading

I put it to draft because i couldn't get it to fail without the fix from #126
I updated all deps to v8 and ts to 5.7

@NullVoxPopuli
Copy link
Member

yea, I had a matrix that tests both es-ts v7 and v8 in another branch, and it still couldn't reproduce the issue.

I feel like we're still missing something.

@patricklx
Copy link
Collaborator Author

I was able to reproduce it before. I'll check again. Might be related to enabled rules

@NullVoxPopuli
Copy link
Member

to clarify, we did merge: #126

@patricklx
Copy link
Collaborator Author

to clarify, we did merge: #126

Yeah, reverted locally

@patricklx
Copy link
Collaborator Author

now i get it: https://github.com/ember-tooling/ember-eslint-parser/actions/runs/13036546297/job/36368381911?pr=127

@NullVoxPopuli
Copy link
Member

Nice!

@patricklx patricklx force-pushed the fix-something branch 4 times, most recently from ebecfd3 to 5b81a28 Compare January 30, 2025 12:30
@patricklx patricklx marked this pull request as ready for review January 30, 2025 12:36
@patricklx patricklx changed the title actually test eslint fix test eslint fix && with different ts eslint plugin versions Jan 30, 2025
@NullVoxPopuli NullVoxPopuli merged commit a0a6561 into main Jan 30, 2025
32 checks passed
@NullVoxPopuli NullVoxPopuli deleted the fix-something branch January 30, 2025 14:11
@github-actions github-actions bot mentioned this pull request Jan 30, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NullVoxPopuli NullVoxPopuli NullVoxPopuli approved these changes

Assignees
No one assigned
Labels
internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@patricklx @NullVoxPopuli