Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the jTDS built-in driver deprecated message #268

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hiroyuki-sato
Copy link
Member

Relates to #267. Remove the jTDS built-in driver in an upcoming release.

@hiroyuki-sato hiroyuki-sato requested a review from a team as a code owner September 12, 2024 10:43
@dmikurube
Copy link
Member

  • It'd be better in general to show such a warning earlier. How about put the log there?
  • Logging in two lines (two log records) could confuse users when the logging is busy. Let's merge this in a single log line. For example:
    • "driver_type: jtds" is specified, but note that the jTDS built-in driver will be removed at some point in the future. Please see https://github.com/embulk/embulk-input-jdbc/issues/267

@hiroyuki-sato
Copy link
Member Author

@dmikurube Sorry for late reply. I realized the driver_path support needs some source modification. This part also need modify. I'm preparing #269 and #270. Convert to draft for a while.

@hiroyuki-sato hiroyuki-sato marked this pull request as draft October 10, 2024 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants