Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI for 5715 #5716

Merged
merged 3 commits into from
Jul 19, 2024
Merged

CI for 5715 #5716

merged 3 commits into from
Jul 19, 2024

Conversation

kflynn
Copy link
Member

@kflynn kflynn commented Jul 5, 2024

CI for #5715 (the fix for #5714) from @sekar-saravanan

Reviewers, this is best done commit by commit:

  • e8ca650 is @sekar-saravanan's actual fix
  • d04280e is my edit to releaseNotes.yml and its corresponding generate CHANGELOG change (and yes, I reworded it to, hopefully, explain the effect of the bug rather than just the internals 🙂)
  • 642c784 is a bunch of whitespace changes from my editor saving releaseNotes.yml that had corresponding changes in the generated CHANGELOG.

Thanks @sekar-saravanan!

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. python Pull requests that update Python code size:M This PR changes 30-99 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Jul 5, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 19, 2024
@kflynn kflynn merged commit 6521f85 into master Jul 19, 2024
40 checks passed
@kflynn kflynn deleted the ci-5715 branch July 19, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer python Pull requests that update Python code size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants