Simplify linker flag handling. NFC #23515
Merged
+147
−150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
force-pushed
the
link_flags_simplify
branch
3 times, most recently
from
d497c69 to
4b3a82f
Compare
sbc100
force-pushed
the
link_flags_simplify
branch
5 times, most recently
from
c5b966a to
4d65a11
Compare
sbc100
requested review from
kripken and
dschuff
and removed request for
kripken
sbc100
force-pushed
the
link_flags_simplify
branch
from
4d65a11 to
4bb9d35
Compare
Linker flags no longer stored in the EmccState and no longer stored along with their original number. Instead, we generate a list of LinkArg objects. We then process these as we compile the inputs, replacing source files with object files as we compile them.
sbc100
force-pushed
the
link_flags_simplify
branch
from
4bb9d35 to
97bde0d
Compare
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Feb 5, 2025
sbc100
added a commit
that referenced
this pull request
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change simplifies the interface between emcc.py (the compiler driver) and link.py (the linker).
Linker flags are no longer stored in the EmccState or stored alongside their ordinal number. Instead passed directly the link.py as a simple list.
This change brings us closer to de-coupling the linker process with the hope of creating a standalone emld entry point.