Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[github] NWjs, nw-builder, node upgrades #520

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ jobs:
- name: setup node
uses: actions/setup-node@v4
with:
node-version: '12'
node-version: '20'
continue-on-error: false

# for debugging
Expand Down Expand Up @@ -87,6 +87,13 @@ jobs:
npm install [email protected] --python=python2.7
continue-on-error: true

- name: Install macos dependencies
run: |
sudo -H pip install setuptools packaging
sudo npm install -g [email protected] node-gyp@10 macos-alias
yarn --network-timeout 1000000
if: ${{ startsWith(matrix.os, 'macos') }}

- name: yarn gulp clean-release
run: yarn gulp clean-release
continue-on-error: true
Expand Down
4 changes: 3 additions & 1 deletion gulpfile.js
Original file line number Diff line number Diff line change
Expand Up @@ -42,11 +42,13 @@
// 0.45.6 Win7 connects; 0.42.3 fixed OSX Flashing; 0.46.X broke Win7 connect. maybe serial/usb needs updating
// reverted to 0.42.6 due to Windows increased CLI-tab buffer/autocomplete issues.
// 0.50.3 is last version to open Links properly. also works on Win11.
// 76+ = node v20.1+
// 83+ = node v21.1+
var NWversion;
if (os.platform() === 'win32') {
NWversion ='0.42.6'
} else {
NWversion ='0.50.3'
NWversion ='0.82.0'

Check warning on line 51 in gulpfile.js

View check run for this annotation

Codacy Production / Codacy Static Code Analysis

gulpfile.js#L51

Avoid using global variables
}

var nwBuilderOptions = {
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@
"karma-sinon-chai": "^2.0.2",
"makensis": "^0.23.4",
"mocha": "^8.1.3",
"nw-builder": "^3.5.7",
"nw-builder": "3.8.3",
"os": "^0.1.2",
"rpm-builder": "^1.2.1",
"sinon": "^9.2.4",
Expand Down
Loading
Loading