Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Types: Fix type annotation for default_encoding parameter #3079

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

JelleZijlstra
Copy link

The default encoding function is allowed to return None, in which case
the encoding property of httpx.Response defaults to utf-8.

The example in https://www.python-httpx.org/advanced/#using-character-set-auto-detection
that passes a default_encoding function uses a function that may return None.

Checklist

  • I understand that this PR may be closed in case there was no previous discussion. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.

The default encoding function is allowed to return None, in which case
the encoding property of httpx.Response defaults to utf-8.

The example in https://www.python-httpx.org/advanced/#using-character-set-auto-detection
that passes a default_encoding function uses a function that may return None.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants