Change default encoding to utf-8 in normalize_header_key
and normalize_header_value
functions
#3241
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This Pull Request addresses the issue of decoding errors encountered when using ASCII encoding in the
normalize_header_key
andnormalize_header_value
functions in_utils.py
. By changing the default encoding to UTF-8, we can handle a wider range of input values without raising errors.Changes
normalize_header_key
andnormalize_header_value
functions from "ascii" to "utf-8".Example Code
Rationale
Using UTF-8 as the default encoding ensures that the functions can handle a wider range of input values without raising an error. UTF-8 encoding is capable of encoding a larger set of characters compared to ASCII.
Additional Context
Here is an example that demonstrates the issue and how the proposed change resolves it:
Checklist