Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #713 and reintroduces a sync Client.
πβ¨ TA-DA! β¨π
We're using
urllib3
here as the backing service for our sync calls.Potentially we could later switch away to using our own
unasync
'ed dispatcher. (Although it's actually feasible that we might just want to stick with urllib3 for the sync case.)If we wanted to tackle this as a set of incremental PRs we would want:
Dispatcher
toAsyncDispatcher
throughout.SyncDispatcher
class.Proxy
config class.BaseClient
.StreamContextManager
to handle both sync and async cases.Also still TODO here:
WSGIDispatcher
class.URLLib3ProxyDispatcher
class.urllib3
exceptions (Need to coverpool.urlopen
andconn.stream
methods)