refactor(ses): stricten commons async gen fn instance error cond

Co-authored-by: legobeat <[email protected]>
endojs · Sep 11, 2024 · 5374cfc · 5374cfc
1 parent cdd2dad
commit 5374cfc
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/packages/ses/src/commons.js b/packages/ses/src/commons.js
@@ -391,9 +391,10 @@ try {
     'return (async function* AsyncGeneratorFunctionInstance() {})',
   )();
 } catch (e) {
-  if (e.name === 'SyntaxError') {
+  // @ts-expect-error ts(2339) Property 'jsEngine' does not exist on type 'Error'. However it exists on Hermes.
+  if (Error.prototype.jsEngine === 'hermes' && e.name === 'SyntaxError') {
     // Swallows Hermes error `async generators are unsupported` at runtime.
-    // @ts-ignore
+    // @ts-expect-error ts(2554) Expected 0 arguments, but got 1. It refers to the Web API Window object, but on Hermes we expect 1 argument.
     // eslint-disable-next-line no-undef
     print('SES: Skipping async generators, unsupported on Hermes');
     // Note: `console` is not a JS built-in, so Hermes engine throws: