fix(ses): Expose ses/console-shim #2460
Merged
+2
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kriskowal
requested review from
mhofman and
gibson042
and removed request for
mhofman
gibson042
approved these changes
Sep 18, 2024
kriskowal
force-pushed
the
kriskowal-ses-console-shim
branch
from
3807295
to
8f653b0
Compare
mhofman
reviewed
Sep 18, 2024
There was a problem hiding this comment.
Doesn't this need an entry in exports in package.json ?
kriskowal
added a commit
that referenced
this pull request
Sep 18, 2024
Stemming from a confusion in #2460, I find that we never exported ses/console-shim.js and that this change was buried in a subsequent change in my stack of coming changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SES exposes
ses/console-shim.jsinpackage.json, but lacked the “thunk” module needed to entrain the actual implementation. Being able to compose all the layers ofsesexceptses/assert-shim.jsproves to be necessary to make progress on parity testing with XS #2252