Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A rework of trick declaration #87

Merged
merged 53 commits into from
Jan 18, 2025
Merged

A rework of trick declaration #87

merged 53 commits into from
Jan 18, 2025

Conversation

StellarWitch7
Copy link
Collaborator

@StellarWitch7 StellarWitch7 commented Jan 8, 2025

This PR aims to improve the declaration of tricks so that overloads are less messy, using a statically-insured signature system. The current TODO is as follows:

  • Solve wards requiring context that is no longer available
  • Refactor every trick
  • Remove the list fragment's address sanitization method and add a generic way to check list types in signatures
  • Implement signature toString
  • Handle no-match scenarios for signature selection
  • Test every trick
  • Move the two distortions in the end of inventory information in ingresses to the distortion category
  • General consistency check between implementation and definitions in the book

@StellarWitch7 StellarWitch7 added the enhancement New feature or request label Jan 8, 2025
@StellarWitch7 StellarWitch7 self-assigned this Jan 8, 2025
@StellarWitch7
Copy link
Collaborator Author

That took a while, but the last couple commits build and run just fine.

@StellarWitch7 StellarWitch7 marked this pull request as ready for review January 18, 2025 00:49
@StellarWitch7 StellarWitch7 requested a review from enjarai January 18, 2025 00:49
@enjarai enjarai merged commit 9ca2e95 into master Jan 18, 2025
2 checks passed
@enjarai enjarai deleted the the-unduckening branch January 18, 2025 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants