EX 01 #150
Open
EX 01 #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akash-ksu
reviewed
May 13, 2020
| ) | ||
|
|
||
| func main() { | ||
| filename := os.Args[1] |
There was a problem hiding this comment.
You might want to handle the scenario when no args or more args are provided before accessing the file name
exercise-001-corpus/word_count.go
Outdated
|
|
||
| func main() { | ||
| filename := os.Args[1] | ||
| data, err := ioutil.ReadFile(string(filename)) |
There was a problem hiding this comment.
os.Args is of type []string no need of an explicit cast here
exercise-001-corpus/corpus/corpus.go
Outdated
|
|
||
| // Analyze takes in a string of words and returns a slice sorted in reverse numerical order based on the word count | ||
| func Analyze(data string) []WordCount { | ||
| words := splitWord(string(data)) |
There was a problem hiding this comment.
You dont need the string(data) case here as well.. data is already a string
| func (a ByCount) Swap(i, j int) { a[i], a[j] = a[j], a[i] } | ||
|
|
||
| func splitWord(word string) []string { | ||
| slice := regexp.MustCompile("[^a-zA-Z0-9']+").Split(word, -1) |
| wordSlice := make([]WordCount, 0) | ||
|
|
||
| for index, word := range words { | ||
| words[index] = strings.ToLower(word) |
There was a problem hiding this comment.
I think you can just iterate over words and increment count in your map
for _, word := range words {
wordMap[word]++
}
the zero value of ints is 0 in go so it should just work out fine
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.