corrects to styling and deleting some unnecessary specs

spec/sidekiq-instrument/client_middleware_spec.rb

@@ -38,7 +38,7 @@
       it 'increments the DogStatsD enqueue counter' do
         expect(
           Sidekiq::Instrument::Statter.dogstatsd
-          ).to receive(:increment).with('sidekiq.enqueue', { tags: ['queue:default', 'worker:my_worker'] }).once
+        ).to receive(:increment).with('sidekiq.enqueue', { tags: ['queue:default', 'worker:my_worker'] }).once
         MyWorker.perform_async
       end
     end
@@ -52,7 +52,7 @@
     end
 
     context 'with WorkerMetrics.enabled true' do
-      it 'increments the enqueue counter' do
+      it 'increments the in_queue counter' do
         Sidekiq::Instrument::WorkerMetrics.enabled = true
         MyOtherWorker.perform_async
         expect(Redis.new.hget(worker_metric_name, 'my_other_worker')).to eq('1')
@@ -75,15 +75,5 @@
         expect { MyWorker.perform_async }.not_to raise_error
       end
     end
-
-    context 'when a job fails' do
-      before do
-        allow_any_instance_of(MyWorker).to receive(:perform).and_raise('foo')
-      end
-
-      it 're-raises the error' do
-        expect { MyWorker.perform_async }.to raise_error 'foo'
-      end
-    end
   end
 end

spec/sidekiq-instrument/server_middleware_spec.rb

@@ -51,16 +51,16 @@
       end
 
       context 'with WorkerMetrics.enabled true' do
-        it 'increments the in queue counter' do
+        it 'decrements the in_queue counter' do
           Sidekiq::Instrument::WorkerMetrics.enabled = true
-          Redis.new.hdel worker_metric_name, 'my_other_worker'
+          Redis.new.hdel(worker_metric_name, 'my_other_worker')
           MyOtherWorker.perform_async
           expect(Redis.new.hget(worker_metric_name, 'my_other_worker')).to eq('-1')
         end
       end
 
       context 'with WorkerMetrics.enabled true and an errored job' do
-        it 'decrements the in queue counter' do
+        it 'decrements the in_queue counter' do
           Sidekiq::Instrument::WorkerMetrics.enabled = true
           MyOtherWorker.perform_async
           expect(Redis.new.hget(worker_metric_name, 'my_other_worker')).to eq('-1')
@@ -103,13 +103,14 @@
         end
       end
 
-      it 'does not increase the redis counter' do
+      it 'decrements the in_queue counter' do
         expect(Redis.new.hget(worker_metric_name, 'my_worker')).to eq(nil)
         begin
           MyWorker.perform_async
         rescue StandardError
           nil
         end
+        expect(Redis.new.hget(worker_metric_name, 'my_worker')).to eq('-1')
       end
 
       it 're-raises the error' do
@@ -119,7 +120,7 @@
       it 'calls the decrement counter' do
         expect(
           Sidekiq::Instrument::WorkerMetrics
-          ).to receive(:trace_workers_decrement_counter).with('my_worker').once
+        ).to receive(:trace_workers_decrement_counter).with('my_worker').once
         begin
           MyWorker.perform_async
         rescue StandardError

spec/sidekiq-instrument/worker_spec.rb

@@ -169,7 +169,7 @@
       it 'increments the DogStatsD failure counter' do
         expect(
           Sidekiq::Instrument::Statter.dogstatsd
-          ).to receive(:increment).with('sidekiq.enqueue', expected_dog_options).once
+        ).to receive(:increment).with('sidekiq.enqueue', expected_dog_options).once
         expect(Sidekiq::Instrument::Statter.dogstatsd).not_to receive(:time)
         begin
           MyWorker.perform_async