draft3

lib/sidekiq/instrument/worker_metrics.rb

@@ -14,7 +14,6 @@ def trace_workers_increment_counter(klass_name, sidekiq_redis_pool_user)
           return unless enabled?
 
           Sidekiq.redis do |redis|
-            # redis.hsetnx(worker_metric_name, klass_name, 0)
             redis.hincrby(worker_metric_name, klass_name, 1)
           end
         end
@@ -23,7 +22,6 @@ def trace_workers_decrement_counter(klass_name)
           return unless enabled?
 
           Sidekiq.redis do |redis|
-            # redis.hsetnx(worker_metric_name, klass_name, 0)
             redis.hincrby(worker_metric_name, klass_name, -1)
           end
         end

spec/sidekiq-instrument/worker_spec.rb

@@ -63,7 +63,7 @@
 
       context 'when jobs in queues' do
         before do
-          Sidekiq.disable! do
+          Sidekiq::Testing.disable! do
             Sidekiq::Queue.all.each(&:clear)
             MyWorker.perform_async
           end
@@ -121,7 +121,7 @@
     end
 
     context 'with server and client middleware' do
-      # let(:expected_dog_options) { { tags: ['queue:default', 'worker:my_worker'] } }
+      let(:expected_dog_options) { { tags: ['queue:default', 'worker:my_other_worker'] } }
       let(:worker_metric_name) do
         "sidekiq_instrument_trace_workers::in_queue"
       end
@@ -160,6 +160,17 @@
           MyOtherWorker.perform_async
           expect(redis.hget(worker_metric_name ,'my_other_worker')).to eq('2')
       end
+
+      it 'increments the DogStatsD failure counter' do
+        expect(Sidekiq::Instrument::Statter.dogstatsd).to receive(:increment).with('sidekiq.enqueue', expected_dog_options).once
+        expect(Sidekiq::Instrument::Statter.dogstatsd).not_to receive(:time)
+        MyOtherWorker.perform_async rescue nil
+      end
+
+      it 'does not increase the redis counter' do
+        expect(Redis.new.hget worker_metric_name ,'my_worker').to eq(nil)
+        MyOtherWorker.perform_async rescue nil
+      end
     end
   end
 end