Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently because the
rescue
only capturesStandardError
type errors, we're not getting into the rescue block for all of the issues Sidekiq workers are experiencing.This PR:
rescue StandardError => e
to now berescue Exception => e
to properly handle gathering stats for all potential error types. The error is re-raised at the end of the rescue so there is no need for concern in widening the umbrella of what we're catching.error
tag to the DataDog stats reported so we can get granular data on what error types our worker's are experiencing