dlb: add how to use #33818
dlb: add how to use #33818
Conversation
|
/docs |
|
Docs for this Pull Request will be rendered here: https://storage.googleapis.com/envoy-pr/33818/docs/index.html The docs are (re-)rendered each time the CI |
|
/retest |
|
/wait on CI |
repokitteh-read-only
bot
added
waiting
deps
|
CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to |
|
@adisuissa sorry for mistake :( |
|
still failing format and publishing ci /wait |
|
Force push to fix DCO. |
|
@phlax please help review :) |
|
/docs |
|
Docs for this Pull Request will be rendered here: https://storage.googleapis.com/envoy-pr/33818/docs/index.html The docs are (re-)rendered each time the CI |
|
@daixiang0 there are a lot of format issues - see https://storage.googleapis.com/envoy-pr/c0fc41e/docs/configuration/other_features/dlb.html could you resolve these first and then i can review |
|
/wait |
|
@phlax please check the latest, CI is happy. |
|
@daixiang0 please look at the rendered docs - they are obviously not correct |
|
/wait-any |
There was a problem hiding this comment.
@daixiang0 im not convinced this is showing anything additional to the install docs
ideally we want to show how the connection is being balanced in some way
examples/dlb/example.rst
Outdated
|
|
||
| The number and PCIE address of DLB devices vary from CPU to CPU. | ||
|
|
||
| Also check your kernel version, 5.15+ is good. |
There was a problem hiding this comment.
this would also require that any relevant kernel modules have been compiled in
surely there is a more reliable way of checking whether a platform has DLB support - esp given the above deviced id is not reliable
There was a problem hiding this comment.
The kernel module is installed by hand, if devices exist, means the platform supports DLB.
|
|
||
| .. code-block:: console | ||
|
|
||
| $ docker run -d -p 12000:80 nginx |
There was a problem hiding this comment.
the sandboxes use compose to start and connect services - this should not be any different
There was a problem hiding this comment.
I know that, but compose is not good at using hardware device in the container, also map the hardware introduce extra knowledge and difficulty for beginners, so here I use docker directly for all actions.
|
/wait-any |
Signed-off-by: Loong <[email protected]>
|
@phlax friendly ping. |
|
as said previously
this cant be tested as it has some very specific platform requirements - i think we can make an exception in this case - but i only think that is justifiable if it brings something extra to the table - eg clear steps to determine platform support and some step showing if/how it works |
Signed-off-by: Loong <[email protected]>
|
@phlax hi, I make support check more clear, and add some output to show how DLB works, hope you like it! |
|
I think this is waiting for your input @phlax |
|
@daixiang0 I think the issue is that platform support is not clear at all. I've tried to look for any sort of pointers as to what CPUs or chipsets support DLB but could not find anything. Is it something that is only available to Intel devs? If not is it possible to link any documentation that tells which hardware platforms can support this. This technology is interesting, but if nobody can try it with the commercially available hardware it will make this example unused. |
|
/wait-any |
| This sandbox provides an example about how to enable DLB connection balanace. | ||
|
|
||
| .. note:: | ||
| Please run below command to check your CPU supports DLB: |
There was a problem hiding this comment.
@yanavlasov I put command here to help users detect its CPU can support DLB.
DLB supports start from 4th Gen Intel Xeon, refer to this doc. I only put detect command in the doc since there are many codename for CPU and users maybe not clear about the exact codename of their own CPUs. I will add above doc link if you want. |
|
gentle ping @phlax @yanavlasov, it seems @daixiang0 already updated, and waiting for next around review. |
|
/wait:review |
|
@phlax PTAL |
|
@daixiang0 the examples have moved now to https://github.com/envoyproxy/examples could you reraise this there, or alternatively if lmk im happy to take it over and raise myself |
|
@phlax sure, I have moved it as envoyproxy/examples#67 |
|
@phlax PTAL. |
|
this can be closed now - there is a follow up here (envoyproxy/examples#67) |
Add doc about how to use.
Commit Message:
Additional Description:
Risk Level: low
Testing: N/A
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]