Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metric_names_for_computing_utilization field to ClientSideWeightedRoundRobin LB Policy proto. #36201

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

efimki
Copy link
Contributor

@efimki efimki commented Sep 18, 2024

Commit Message:
Add metric_names_for_computing_utilization field to ClientSideWeightedRoundRobin LB Policy config proto.

Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: n/a

#34777

…htedRoundRobin` LB policy.

Signed-off-by: Misha Efimov <[email protected]>
Copy link

CC @envoyproxy/api-shepherds: Your approval is needed for changes made to (api/envoy/|docs/root/api-docs/).
envoyproxy/api-shepherds assignee is @markdroth
CC @envoyproxy/api-watchers: FYI only for changes made to (api/envoy/|docs/root/api-docs/).

🐱

Caused by: #36201 was opened by efimki.

see: more, trace.

@efimki
Copy link
Contributor Author

efimki commented Sep 18, 2024

/assign @adisuissa

@efimki
Copy link
Contributor Author

efimki commented Sep 18, 2024

/assign @wbpcode

@markdroth
Copy link
Contributor

/lgtm api

Copy link
Contributor

@adisuissa adisuissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@efimki
Copy link
Contributor Author

efimki commented Sep 19, 2024

/retest

@zuercher zuercher merged commit 135a6a2 into envoyproxy:main Sep 20, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants