Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http2: fix reported protocol error from graceful upstream close #36205

Merged
merged 2 commits into from
Sep 20, 2024

Conversation

ggreenway
Copy link
Contributor

Risk Level: Medium
Testing: Added new tests
Release Notes: added
Runtime guard: envoy.reloadable_features.http2_no_protocol_error_upon_clean_close
Fixes #21522

Copy link

CC @envoyproxy/runtime-guard-changes: FYI only for changes made to (source/common/runtime/runtime_features.cc).

🐱

Caused by: #36205 was opened by ggreenway.

see: more, trace.

Signed-off-by: Greg Greenway <[email protected]>
@zuercher
Copy link
Member

/assign-from @envoyproxy/envoy-maintainers

Copy link

@envoyproxy/envoy-maintainers assignee is @ggreenway

🐱

Caused by: a #36205 (comment) was created by @zuercher.

see: more, trace.

@zuercher zuercher assigned yanavlasov and unassigned ggreenway Sep 20, 2024
@yanavlasov yanavlasov merged commit bb22882 into envoyproxy:main Sep 20, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

envoy reports protocol error each time it handles an upstream goaway frame
3 participants