Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bp/1.31] repo: Move examples to own repo (#35471) #36218

Merged
merged 2 commits into from
Sep 20, 2024

Conversation

phlax
Copy link
Member

@phlax phlax commented Sep 19, 2024

fix #32737


Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

@phlax phlax marked this pull request as draft September 19, 2024 12:52
@repokitteh-read-only repokitteh-read-only bot added the deps Approval required for changes to Envoy's external dependencies label Sep 19, 2024
Copy link

CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch).
envoyproxy/dependency-shepherds assignee is @RyanTheOptimist

🐱

Caused by: #36218 was opened by phlax.

see: more, trace.

fix envoyproxy#32737

---------

Signed-off-by: Ryan Northey <[email protected]>

Signed-off-by: phlax <[email protected]>
@phlax phlax changed the title [WIP/bp/1.31] repo: Move examples to own repo (#35471) [bp/1.31] repo: Move examples to own repo (#35471) Sep 20, 2024
@phlax phlax marked this pull request as ready for review September 20, 2024 12:15
@phlax phlax enabled auto-merge (rebase) September 20, 2024 12:15
see also envoyproxy#32737 and
envoyproxy#32737 (comment),

Commit Message: update git repo url in docs to refer to the new examples
repo
Additional Description: might fix docs
Risk Level: none
Testing: none
Docs Changes: changes docs/root/start/sandboxes/setup.rst to refer to
the right github repo (examples)

---------

Signed-off-by: David Goodwin <[email protected]>
Signed-off-by: Ryan Northey <[email protected]>
@phlax phlax merged commit fd56cad into envoyproxy:release/v1.31 Sep 20, 2024
39 of 40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deps Approval required for changes to Envoy's external dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants