Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cds: set config_reload and config_reload_time_ms #38638

Merged
merged 3 commits into from
Mar 11, 2025

Conversation

dkumazawa
Copy link
Contributor

Commit Message: Records config_reload and config_reload_time_ms statistics when cds makes a non-empty update.
Additional Description: N/A
Risk Level: Low
Testing: Unit tests have been updated to validate that the new stats are properly set.
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A

#38490

Copy link

Hi @dkumazawa, welcome and thank you for your contribution.

We will try to review your Pull Request as quickly as possible.

In the meantime, please take a look at the contribution guidelines if you have not done so already.

🐱

Caused by: #38638 was opened by dkumazawa.

see: more, trace.

Signed-off-by: Daiki Kumazawa <[email protected]>
@dkumazawa
Copy link
Contributor Author

There's one error from //test/extensions/filters/http/wasm:wasm_filter_integration_test in tsan. I'm wondering if this is just a flake given the previous invocation was successful.

@dkumazawa
Copy link
Contributor Author

/retest

Copy link
Member

@zuercher zuercher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks!

@dkumazawa
Copy link
Contributor Author

dkumazawa commented Mar 7, 2025

Thank you @zuercher for your review! @yanavlasov please let me know if you could help provide maintainer review workflow approval or if I should reach out elsewhere (apologies for the noob question as this is my first PR to Envoy!)

@KBaichoo KBaichoo merged commit b7ce51d into envoyproxy:main Mar 11, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants