feat(translator): implement httproutefilter and path regex rewrite #4258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guydc
force-pushed
the
feat-translator-hrf
branch
from
a238a26
to
11acbb1
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4258 +/- ##
==========================================
- Coverage 65.75% 65.74% -0.01%
==========================================
Files 197 197
Lines 23565 23763 +198
==========================================
+ Hits 15494 15623 +129
- Misses 6967 7020 +53
- Partials 1104 1120 +16 ☔ View full report in Codecov by Sentry. |
guydc
force-pushed
the
feat-translator-hrf
branch
5 times, most recently
from
2a9fe55
to
3c5c126
Compare
Signed-off-by: Guy Daich <[email protected]>
guydc
force-pushed
the
feat-translator-hrf
branch
from
3c5c126
to
657bbf0
Compare
zhaohuabing
reviewed
Sep 23, 2024
| for _, rule := range httproute.Spec.Rules { | ||
| for _, filter := range rule.Filters { | ||
| if filter.ExtensionRef != nil && string(filter.ExtensionRef.Kind) == resource.KindHTTPRouteFilter { | ||
| // If an explicit Backend namespace is not provided, use the HTTPRoute namespace to |
There was a problem hiding this comment.
Nit: remove this comment. Cross-namespace filter reference is not supported.
zhaohuabing
previously approved these changes
Sep 23, 2024
arkodg
reviewed
Sep 23, 2024
internal/ir/xds.go
Outdated
| type ExtendedHTTPPathModifier struct { | ||
| HTTPPathModifier `json:",inline" yaml:",inline"` | ||
| // RegexMatchReplace provides a regex to match an a replacement to perform on the path. | ||
| RegexMatchReplace *RegexMatchReplace `json:"regexMatchReplace" yaml:"regexMatchReplace"` |
|
one nit around tag, else LGTM, thanks for adding this ! |
Signed-off-by: Guy Daich <[email protected]>
zirain
approved these changes
Sep 23, 2024
arkodg
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
HTTPRouteFilterWhich issue(s) this PR fixes:
Fixes #4120, #1794