Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OIDC: add nonce support to the oauth2 filter #4271

Merged
merged 3 commits into from
Sep 18, 2024

Conversation

zhaohuabing
Copy link
Member

@zhaohuabing zhaohuabing commented Sep 18, 2024

This PR introduce nonce support to the oauth2 authentication flow, enhancing EG's security posture by preventing malicious users from injecting their own access token into a victim's session through CSRF attacks.

Additional background information can be found at:

Signed-off-by: Huabing Zhao <[email protected]>
@zhaohuabing zhaohuabing requested a review from a team as a code owner September 18, 2024 01:33
@zhaohuabing zhaohuabing added envoy-release-dependency release-note Indicates a required release note labels Sep 18, 2024
Copy link

codecov bot commented Sep 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.64%. Comparing base (eff9611) to head (66af17e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4271      +/-   ##
==========================================
- Coverage   65.64%   65.64%   -0.01%     
==========================================
  Files         197      197              
  Lines       23551    23552       +1     
==========================================
  Hits        15460    15460              
  Misses       6979     6979              
- Partials     1112     1113       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Huabing Zhao <[email protected]>
@zhaohuabing zhaohuabing removed the release-note Indicates a required release note label Sep 18, 2024
Copy link
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 thanks for adding this in upstream @zhaohuabing !

Copy link
Member

@Xunzhuo Xunzhuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice works! Thanks @zhaohuabing

@zhaohuabing zhaohuabing merged commit d00737b into envoyproxy:main Sep 18, 2024
24 checks passed
@zhaohuabing zhaohuabing deleted the oauth2-nonce branch September 18, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants