Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e: add tests for ratelimit invert matching headers #4452

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

rudrakhp
Copy link
Contributor

What type of PR is this?

E2E tests for feature PR #4286

What this PR does / why we need it:

E2E tests

Which issue(s) this PR fixes:

Ref #2193

@rudrakhp rudrakhp requested a review from a team as a code owner October 16, 2024 09:24
@rudrakhp rudrakhp force-pushed the ratelimit_invert_match_headers_e2e branch from d93c2b7 to 9ba0528 Compare October 16, 2024 09:25
Copy link

codecov bot commented Oct 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.79%. Comparing base (5a1c065) to head (4a3445b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4452      +/-   ##
==========================================
- Coverage   65.80%   65.79%   -0.02%     
==========================================
  Files         203      203              
  Lines       30696    30696              
==========================================
- Hits        20200    20196       -4     
- Misses       9341     9344       +3     
- Partials     1155     1156       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rudrakhp rudrakhp force-pushed the ratelimit_invert_match_headers_e2e branch from aee62d6 to 4a3445b Compare October 18, 2024 04:22
@rudrakhp rudrakhp marked this pull request as ready for review October 18, 2024 04:22
@rudrakhp
Copy link
Contributor Author

Looks like some other E2E test is failing, it might due to some intermittent issue unrelated to the new RateLimitHeaderInvertMatch test:

2024-10-18T04:54:34.5281977Z     --- FAIL: TestE2E/ClientMTLS (121.16s)
2024-10-18T04:54:34.5282535Z         --- FAIL: TestE2E/ClientMTLS/Use_Client_MTLS (61.01s)
2024-10-18T04:54:34.5283217Z         --- FAIL: TestE2E/ClientMTLS/Client_TLS_Settings_Enforced (60.01s)

Copy link
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks !

@arkodg arkodg requested review from a team October 18, 2024 21:33
@arkodg arkodg merged commit 272da6d into envoyproxy:main Oct 18, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants