docs: add docs for ratelimit invert match headers #4483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rudrakhp
force-pushed
the
ratelimit_invert_match_headers_docs
branch
from
b34764d
to
b19b8ab
Compare
|
Added docs manually but |
|
you should update docs under docs alias to current version, which means |
rudrakhp
force-pushed
the
ratelimit_invert_match_headers_docs
branch
2 times, most recently
from
01f9503
to
4056304
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4483 +/- ##
=======================================
Coverage 65.97% 65.98%
=======================================
Files 203 203
Lines 31154 31154
=======================================
+ Hits 20554 20556 +2
+ Misses 9415 9414 -1
+ Partials 1185 1184 -1 ☔ View full report in Codecov by Sentry. |
zhaohuabing
reviewed
Oct 21, 2024
zhaohuabing
previously approved these changes
Oct 21, 2024
rudrakhp
force-pushed
the
ratelimit_invert_match_headers_docs
branch
from
4056304
to
c286335
Compare
Signed-off-by: Rudrakh Panigrahi <[email protected]>
rudrakhp
force-pushed
the
ratelimit_invert_match_headers_docs
branch
from
c286335
to
08352e0
Compare
Signed-off-by: Rudrakh Panigrahi <[email protected]>
rudrakhp
force-pushed
the
ratelimit_invert_match_headers_docs
branch
from
8c49b64
to
2aacb82
Compare
zhaohuabing
approved these changes
Oct 22, 2024
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
docs: add docs for ratelimit invert match headers
api: remove
notImplementedHideforInvertfeaturee2e: add a test for invert header match in local ratelimit case
What this PR does / why we need it:
Docs for feature implemented in #4286
Which issue(s) this PR fixes:
Fixes #2193