Retain class inheritance #62
Open
+27
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bisaloo
requested changes
Jan 28, 2025
Comment on lines
+62
to
+64
| current_classes <- class(x) | ||
| df_index <- which(current_classes == "data.frame") | ||
| class(x) <- append(current_classes, "safeframe", after = df_index - 1) |
There was a problem hiding this comment.
As shown in the proposed new test, this will come short in complex cases where the safeframe is a subclass of a data.frame (e.g., a tibble).
I think the only solution is to restore the class in the function where it's dropped (i.e., the subsetting functions) and to restore a copy of the original class
Co-authored-by: Hugo Gruson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the
restore_labelsfunction to ensure "safeframe" gets added before data.frame as the relevant subclass, but does not gets prioritized over potential other internal classes.Fixes #56. Includes the reproducible example from #56 as a test to ensure it stays fixed 😊