Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document & test dependency on R 4.1.0 #268

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

Bisaloo
Copy link
Member

@Bisaloo Bisaloo commented Dec 10, 2024

Fix #266

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (6e09927) to head (130946f).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #268   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            6         6           
  Lines         1015      1015           
=========================================
  Hits          1015      1015           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Bisaloo
Copy link
Member Author

Bisaloo commented Dec 10, 2024

CI failure is related to #174.

I would probably recommend resolving #174 before moving forward if that's an option. Having an (indirect) dependency on R 4.2 is probably a bit early.

@ntorresd
Copy link
Member

I rebased and now the issue I mentioned in #273 about pandoc is appearing here. I was hoping that updating the minimum version of R required would prevent it, but it's now appearing in ubuntu-latest:
image

@Bisaloo
Copy link
Member Author

Bisaloo commented Jan 30, 2025

I re-ran the workflow and it seems all good now. R 4.1.0 on ubuntu is failing for a reason unrelated to pandoc as far as I can tell.

I think the pandoc issue is related to the fact that pandoc-citeproc no longer exists in ubuntu 24.04 but it's unclear to me why it pops up sometimes still. Maybe an issue with the sysreqs API that doesn't get the right platform information 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document dependency on R 4.1
3 participants