Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: API Sync by GitHub Action for @displague #89

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Feb 5, 2025

This API Sync PR was triggered by @displague through GitHub Actions workflow_displatch
on 2025-02-05.

  • latest Swagger is fetched
  • patches have been applied
  • generated client has been updated

Copy link
Contributor Author

github-actions bot commented Feb 5, 2025

Failed to generate code from latest patched spec. Someone with write access must fix this PR manually and then convert it from Draft status to Ready for Review.

@displague
Copy link
Member

displague commented Feb 5, 2025

@ctreatma Why are the changes in the "sync: uncommitted changes" commit considered a build failure rather than "new stuff based on the spec, captured by git add -A, to add to the SDK"? Is the intention that such changes should be closely monitored and manually applied?

@ctreatma
Copy link
Contributor

ctreatma commented Feb 5, 2025

The codegen changes weren't committed at the end of the codegen step because there was an error during the codegen step. In this case the metro input param generates invalid code due to a bug in the generator: https://github.com/equinix/equinix-sdk-go/pull/89/files#diff-9e28bf0c86d405f9d6a436edb06888b9c3b0ec9cff75b7f59e2dbbe555650b03R17-R20

The sync job automatically commits any uncommitted changes before opening a PR so that those changes aren't lost after the job is done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants