Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type hints Fix #1698

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Type hints Fix #1698

wants to merge 1 commit into from

Conversation

ZhipengXue97
Copy link

@ZhipengXue97 ZhipengXue97 commented Jul 10, 2024

Description

Fix type check warning reported by Pyre@Google, which was outdated after code modification.

Detail

update the return type of function _read_dict() from dict to Mapping, since the condition check of the return new_dict and type Mapping after commit 9193b1f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant