-
-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: typescript (jsdoc) checking and definition generation #169
Conversation
How's the progress on this one? eslint v9 is feature frozen, and this is the last one in v17. |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
No hurry, please take your time. I just want to make sure we did not lose track of it. 😄 |
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here's some late evening comments, didn't have time to look through all code unfortunately but overall I really really like it and it really rhymes with what I'm trying to do in eslint-community/eslint-utils#204 (and somewhat over the top in eslint/eslint-visitor-keys#66)
Co-authored-by: Sebastian Good <[email protected]>
], | ||
"peerDependencies": { | ||
"eslint": ">=8.23.0" | ||
}, | ||
"dependencies": { | ||
"@eslint-community/eslint-utils": "^4.4.0", | ||
"@types/eslint": "^8.56.2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we remove it here - it's already listed in devDependencies
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunatly we can't until #213 is done as the types require the dependency :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's merge and then file PR:s for any follow up improvements.
Would be great to get into next release.
I'm merging it and going to push a pre-release. |
@@ -133,11 +133,11 @@ | |||
}, | |||
"no-date-prototype-getyear-setyear": { | |||
"supported": ">=0.10.0", | |||
"deprecated": true | |||
"supported": ">=0.10.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
duplicate line with line 135
This is aiming to resolve #142