Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add test for ESLint v9 #186

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

test: add test for ESLint v9 #186

wants to merge 3 commits into from

Conversation

ota-meshi
Copy link
Member

close #183

@ota-meshi ota-meshi marked this pull request as draft January 10, 2024 08:47
Copy link

codecov bot commented Jan 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.95%. Comparing base (0c21af5) to head (8b2da74).
Report is 3 commits behind head on main.

❗ Current head 8b2da74 differs from pull request most recent head a1fd76d. Consider uploading reports for the commit a1fd76d to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #186   +/-   ##
=======================================
  Coverage   96.95%   96.95%           
=======================================
  Files          13       13           
  Lines        2102     2102           
  Branches      397      397           
=======================================
  Hits         2038     2038           
  Misses         63       63           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ota-meshi ota-meshi marked this pull request as ready for review January 10, 2024 09:46
@fisker
Copy link

fisker commented Jan 12, 2024

@ota-meshi

"eslint": "^6.0.0 || ^7.0.0 || >=8.0.0"

@fisker
Copy link

fisker commented Feb 18, 2024

Any plan to release a new version?

@voxpelli
Copy link
Member

voxpelli commented Mar 8, 2024

This doesn't just add a test, it also fixes compatibility, right?

@ota-meshi
Copy link
Member Author

I think it's already compatible with v9 (>=8.0.0).
If you use the pre-release, you only need to force install it. Or do you think we also have to do a pre-release?

@voxpelli
Copy link
Member

Opened a separate PR for allowing ESLint 9 pre-releases, as that's what's needed for eg. @fisker to be unblocked with eslint-plugin-unicorn: #206

I will review this one separately as its about testing to ensure that we actually work as expected with it, which as you say @ota-meshi we should be 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support ESLint 9
3 participants