Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: align Node.js version support with ESLint 9 #234

Closed
wants to merge 1 commit into from

Conversation

voxpelli
Copy link
Member

Fixes #232 and considering the feedback in #233 (comment) it seems like there will be no real downsides to this.

@voxpelli voxpelli added the BREAKING CHANGE This change will require a major version bump label Sep 18, 2024
@voxpelli voxpelli self-assigned this Sep 18, 2024
@voxpelli voxpelli requested a review from a team September 18, 2024 15:23
Copy link

@scagood scagood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me

Copy link
Member

@MichaelDeBoey MichaelDeBoey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should update GitHub workflows as well

@MichaelDeBoey
Copy link
Member

Superseded by #242

@MichaelDeBoey MichaelDeBoey deleted the voxpelli/issue232 branch October 26, 2024 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BREAKING CHANGE This change will require a major version bump
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop older node versions from engines.node (align with ESLint 9?)
3 participants