Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use [email protected] #584

Merged
merged 1 commit into from
Aug 24, 2023
Merged

chore: use [email protected] #584

merged 1 commit into from
Aug 24, 2023

Conversation

mdjermanovic
Copy link
Member

Switches to [email protected], which simplifies usage in our ESM projects.

I checked with --print-config that configurations for .js and .cjs files are the same as before this change, except for 3 rules that are no longer enabled for ESM files (eslint/eslint#17336 (comment)).

Comment on lines -28 to -34
{
settings: {
jsdoc: {
mode: "typescript"
}
}
},
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is now included in eslint-config-eslint (eslint/eslint#17338).

Copy link
Member

@aladdin-add aladdin-add left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@aladdin-add aladdin-add merged commit ec949bc into main Aug 24, 2023
14 checks passed
@github-actions github-actions bot mentioned this pull request Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants