Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct exports field in package.json #279

Merged
merged 3 commits into from
Sep 2, 2024
Merged

Conversation

ocavue
Copy link
Contributor

@ocavue ocavue commented Sep 2, 2024

Closes #278

Based on the Node.js docs (link), I can't say for sure that the existing exports field is invalid, but it is certainly uncommon, which might be the issue behind #278. I updated the exports field to a more common format as described in the Node.js docs, and based on my testing, it does fix #278.

@eslint-github-bot eslint-github-bot bot added the bug label Sep 2, 2024
Copy link

linux-foundation-easycla bot commented Sep 2, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

@nzakas
Copy link
Member

nzakas commented Sep 2, 2024

Thanks for the PR! Can you also add an entry for types? It seems like some tools will want that along with the default export.

@ocavue
Copy link
Contributor Author

ocavue commented Sep 2, 2024

Added.

Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@nzakas nzakas merged commit 8e40d30 into eslint:main Sep 2, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants