[DMA 5/N]: Clean up duplicate PDMA instance macro #2527
+1,467
−1,271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugadani
force-pushed
the
dma3
branch
4 times, most recently
from
3af506e
to
e10b28f
Compare
|
fwiw, the last commit LGTM. (Idk if it's easier to get this in earlier to avoid rebasing it) |
|
I'm rebasing this PR over and over again so that I can have an overview of what I'm missing. The idea of the macro dedup came a bit too late, I'd rather not pull it up and rebase over it, especially since it doesn't matter that much. |
bugadani
commented
Nov 13, 2024
| #[doc = concat!("DMA channel suitable for I2S", $num)] | ||
| pub struct [<I2s $num DmaChannel>] {} | ||
| #[doc = concat!("DMA channel suitable for ", stringify!([< $peri:upper >]), $num)] | ||
| #[non_exhaustive] |
There was a problem hiding this comment.
I guess this bug has lived long enough, no more safely constructed I2S DMA channels 🙃
There was a problem hiding this comment.
Iirc this is just a marker type anyway
There was a problem hiding this comment.
Not anymore, these are the channel "peripherals".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for your contribution!
We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:
Submission Checklist 📝
cargo xtask fmt-packagescommand to ensure that all changed code is formatted correctly.CHANGELOG.mdin the proper section.Extra:
Pull Request Details 📖
Description
Please provide a clear and concise description of your changes, including the motivation behind these changes. The context is crucial for the reviewers.
Testing
Describe how you tested your changes.