Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix macOS installation #602

Merged
merged 3 commits into from
Mar 4, 2024
Merged

Conversation

SergioGasquez
Copy link
Member

@SergioGasquez SergioGasquez commented Feb 26, 2024

Draft until we confirm that #597 is solved with this dependency update.

@NobodyXu
Copy link

CI doesn't seem to fail though?

@SergioGasquez
Copy link
Member Author

CI also succeed while using cc 1.0.86 in other branch: https://github.com/SergioGasquez/espflash/actions/runs/8018297785. Not sure what make version they are using

@NobodyXu
Copy link

Not sure what make version they are using

The default make on macos-14 (probably also macos-latest) is old enough to reproduce the error.

Does it fail locally on your machine, but not the CI?

What make are you using?

@playfulFence
Copy link
Contributor

make which causes an error - "GNU Make 3.81"
make which works correctly - "GNU Make 4.4.1"

@NobodyXu
Copy link

That's the same error in rust-lang/cc-rs#962 , have to re-investigate on this

@SergioGasquez
Copy link
Member Author

Just updated this branch to use cc 1.0.89 and seems to solve the issue!

@SergioGasquez SergioGasquez marked this pull request as ready for review March 4, 2024 10:22
@playfulFence
Copy link
Contributor

@SergioGasquez Just tested it on good old "infamous" 3.81 , worked for me!
Thanks for taking care of this 😄

@SergioGasquez SergioGasquez merged commit aceb99a into esp-rs:main Mar 4, 2024
28 checks passed
@SergioGasquez SergioGasquez deleted the fix/mac-install branch March 4, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog Skips the changelog CI check
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cargo install cargo-espflash fails with error of build command for openssl-sys v0.9.101
3 participants