-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
esp_tinyusb v1.4.3: ESP32P4 HS only support #292
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@roma-jam Thanks for the update!
Overall LGTM, let me test on HW and we can go ahead with merging
f429112
to
b6c93eb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@roma-jam Left some nitpicks but LGTM otherwise
b6c93eb
to
dcdb8a9
Compare
Hey @tore-espressif @Dazza0, The API doesn't changed (I left the name of I kept the commit history changes available, just for easier understanding of changes. (I will clean it right before merge) UPD: Changes reverted. |
@roma-jam Please also have a look And how it is used in tinyusb official examples. |
@tore-espressif The Anyway, to be able to return response to the Otherwise, we need dynamically provide the correct descriptor. |
62b6af3
to
3e150ef
Compare
3e150ef
to
7cdc22e
Compare
Checklist
url
field definedChanges
Hint: For better experience and verification use TinyUSB v0.15.0~4